Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bump: add utils/repology require #17717

Merged
merged 1 commit into from
Jul 14, 2024
Merged

bump: add utils/repology require #17717

merged 1 commit into from
Jul 14, 2024

Conversation

samford
Copy link
Member

@samford samford commented Jul 14, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A recent PR reworked requires to improve performance (#17707) but this led to an uninitialized constant Homebrew::DevCmd::Bump::Repology error in brew bump. This adds a utils/repology require to dev-cmd/bump.rb to resolve the error.

@samford
bump: add utils/repology require
ae06033 
A recent commit reworked `require`s to improve performance but this
led to an `uninitialized constant Homebrew::DevCmd::Bump::Repology`
error in `brew bump`. This adds a `utils/repology` `require` to
`dev-cmd/bump.rb` to resolve the error.
@samford samford mentioned this pull request Jul 14, 2024
Merged
MikeMcQuaid
MikeMcQuaid approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samford!

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 14, 2024 14:17
@MikeMcQuaid MikeMcQuaid merged commit 320185a into Homebrew:master Jul 14, 2024
25 checks passed
@samford samford deleted the bump-add-repology-require branch July 14, 2024 14:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samford @MikeMcQuaid